Skip to content

Smoketests for default values (and fix bugs) - #5618

Open
bfops wants to merge 35 commits into
masterfrom
bfops/consolidate-default-tests
Open

Smoketests for default values (and fix bugs)#5618
bfops wants to merge 35 commits into
masterfrom
bfops/consolidate-default-tests

Conversation

@bfops

@bfops bfops commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Description of Changes

Motivated by #5562, this PR adds smoketests for default column values in all suported languages.

This uncovered multiple bugs:

API and ABI breaking changes

None. New tests only.

Expected complexity level and risk

2

Testing

  • CI passes
  • CI correctly failed on broken default values

@bfops
bfops changed the base branch from master to bfops/test-suite-fixes July 29, 2026 17:58
@bfops bfops changed the title [Spelunking] C++/Rust schema compare tests Smoketests for default values Jul 29, 2026
@bfops
bfops marked this pull request as ready for review July 29, 2026 19:18
Comment thread crates/smoketests/tests/smoketests/column_defaults.rs Outdated
@bfops
bfops changed the base branch from bfops/test-suite-fixes to master July 30, 2026 03:59
@bfops
bfops requested a review from gefjon July 30, 2026 14:27
Comment thread crates/smoketests/tests/smoketests/column_defaults.rs Outdated
Comment thread crates/smoketests/tests/smoketests/column_defaults.rs
# Description of Changes
Fixes #5623
Fixes #5624
Fixes #5627
Fixes #5622

# API and ABI breaking changes

No. Fixes bugs with things that won't working (two build failures, one
publish failure, and one incorrect default value)

# Expected complexity level and risk

2

# Testing

- [x] Further smoketest cases have been enabled
- [x] modules in those smoketests are building and publishing
successfully

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Co-authored-by: clockwork-labs-bot <clockwork-labs-bot@users.noreply.github.com>
@bfops bfops changed the title Smoketests for default values Smoketests for default values (and fix bugs) Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants